Generic client type for OpenAiService#159
Merged
dsgrieve merged 1 commit intomicrosoft:mainfrom Jul 30, 2024
dsgrieve:generic-client-type
Merged
Generic client type for OpenAiService#159dsgrieve merged 1 commit intomicrosoft:mainfrom dsgrieve:generic-client-type
dsgrieve merged 1 commit intomicrosoft:mainfrom
dsgrieve:generic-client-type
Conversation
johnoliver
approved these changes
Jul 30, 2024
milderhc
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Working on Assistants API and the client is an AssistantsAsyncClient, not an OpenAIAsyncClient.
Description
Change OpenAiService so that the
clientis generic. This also forces a change in OpenAiServiceBuilder to include a generic client type.Contribution Checklist